Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4502 - allow changing of close response from jetty and javax websocket onClose events #4523

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Issue #4502 - allow changing of close response from jetty and javax websocket onClose events #4523

merged 3 commits into from
Jan 29, 2020

Conversation

lachlan-roberts
Copy link
Contributor

Issue #4502

Allow sending frames or custom close codes from Jetty WebSocket onWebSocketClose event or the java.websocket onClose event.

Closes #4502

@lachlan-roberts
Issue #4502 - onClose can now be triggered on receiving a close frame
4ef208e 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Issue #4502 - add onClose tests for Jetty and Javax WS APIs
fdd27a9 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Fix broken test cases
8638fb2 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
sbordet requested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of throwing from close(), but I'm not going to argue about it.
Notify-only-once needs to be fixed.

jetty-util/src/main/java/org/eclipse/jetty/util/FutureCallback.java Show resolved Hide resolved
...ommon/src/main/java/org/eclipse/jetty/websocket/javax/common/JavaxWebSocketFrameHandler.java Show resolved Hide resolved
...etty-common/src/main/java/org/eclipse/jetty/websocket/common/JettyWebSocketFrameHandler.java Show resolved Hide resolved
@lachlan-roberts lachlan-roberts merged commit 19354d0 into jetty-10.0.x Jan 29, 2020
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-4502-wsOnClose branch January 29, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw left review comments

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

respond to close frame with custom close code in jetty-10 websocket
3 participants
@lachlan-roberts @gregw @sbordet